Update syntax style on examples #731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -355,7 +355,7 @@ iex> list = [1|[2|[3|[]]]] | |||
| This means accessing the length of a list is a linear operation: we need to traverse the whole list in order to figure out its size. Updating a list is fast as long as we are prepending elements: | |||
|
|
|||
| ```iex | |||
| iex> [0 | list] | |||
| iex> [0|list] | |||
There was a problem hiding this comment.
Maybe it's better if we keep this with spaces, given there's a discussion in an Elixir PR around deciding on the [x | y] style once and for all, throughout all Elixir's codebase. :) Same applies to the other occurrences below.
There was a problem hiding this comment.
I have a commit ready to send fixing all the spaces around the |,
I will send it soon
|
@alfakini can you please send a PR that only takes the space from the right of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some nits :)